Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8431" |
wilzbach
force-pushed
the
gdc-8
branch
4 times, most recently
from
fcf7bc9 to
2e1cbd3
Compare
wilzbach
force-pushed
the
gdc-8
branch
2 times, most recently
from
5e2e6e8 to
1ac2948
Compare
wilzbach
force-pushed
the
gdc-8
branch
2 times, most recently
from
282dd93 to
12a509d
Compare
wilzbach
removed
the
Review:WIP
|
Nice - looks like it's working:
Note that the build time of the gdc job was already pretty high and is something that can be addressed in another PR (if it's even easy to address):
|
wilzbach
added
the
Review:Blocking Other Work
Geod24
left a comment
Geod24
left a comment
There was a problem hiding this comment.
It's pretty ugly, but if it works...
ci.sh
Outdated
| mkdir -p ~/dlang/gdc-8 | ||
| sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc | ||
| echo "deactivate(){ echo;}" > ~/dlang/gdc-8/activate | ||
| sed -i "s/-vtls //" -i src/posix.mak # gdmd doesn't support -vtls |
There was a problem hiding this comment.
Ah sorry. gdmd already supports it and translates it to -fd-vtls, but it seems like support for it was removed in gdc - the error is simply:
gdc: error: unrecognized command line option ‘-fd-vtls’
There was a problem hiding this comment.
Ah, yes that ugly option is gone. And replaced with -ftransition=tls. Can add a condition to pick one or the other based on the gcc version.
wilzbach
force-pushed
the
gdc-8
branch
2 times, most recently
from
46ab1cb to
b31521a
Compare
ci.sh
Outdated
| mkdir -p ~/dlang/gdc-8 | ||
| sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc | ||
| echo "deactivate(){ echo;}" > ~/dlang/gdc-8/activate | ||
| sed -i "s/-vtls //" -i src/posix.mak # gdc-8 doesn't support -fd-vtls |
There was a problem hiding this comment.
Wow that was pretty fast. Thanks a lot!
ci.sh
Outdated
| sudo chmod +x /usr/bin/gdmd | ||
| # fake install script and create a fake 'activate' script | ||
| mkdir -p ~/dlang/gdc-8 | ||
| sudo ln -s /usr/bin/gdc-8 /usr/bin/gdc |
There was a problem hiding this comment.
And lastly, if you save the gdmd script to /usr/bin/gdmd-8, you wouldn't need this symlink. I guess you'd need to export DMD=gdmd-8 ?
|
@wilzbach - Oops, looks like the compiler was built |
5 participants
Trying out @ibuclaw's suggestion of using a special Ubuntu PPA.