Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8565" |
PetarKirov
approved these changes
Aug 14, 2018
Member
|
To clarify my stance, I think it is a reasonable request to ensure that the last two releases of gdc work with compiling dmd. When gdc-9 is out, you can drop gdc-7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also:
CC @ibuclaw
I already configured another gdc-7 job at SemaphoreCI.
With the free plan we can only run four jobs in parallel, but this seems to be important to the GDC project and also the long-term plan is to migrate all SemaphoreCI tests to Buildkite runners (e.g. dlang/ci#261) where we can just arbitrarily (and cheaply!) add new runners (we already have ten agents there).
I know that this way of hacking with the Ubuntu PPA isn't ideal, but as long as the install.sh doesn't support newer GDC binaries, this is an easy workaround.