Skip to content

Comments

fix Issue 19201 - func called with argument types (ulong) matches both: __c_long and __c_ulong#8632

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:issue19201
Aug 28, 2018
Merged

fix Issue 19201 - func called with argument types (ulong) matches both: __c_long and __c_ulong#8632
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:issue19201

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Aug 28, 2018

I don't see any valid reason for the limitation, and gdc builds are broken.

@ibuclaw ibuclaw added the Compiler:GDC Gnu D Compiler label Aug 28, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
19201 blocker Error: func called with argument types (ulong) matches both: __c_long and __c_ulong

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8632"

Copy link
Member

@UplinkCoder UplinkCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlang-bot dlang-bot merged commit 4b2c885 into dlang:master Aug 28, 2018
@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 28, 2018

@jacob-carlborg - I was going to wait for the original author to explain himself.

@jacob-carlborg
Copy link
Contributor

I was going to wait for the original author to explain himself.

Please mention that the next time. Feel free to revert if you want to.

/* Special enums that allow implicit conversions to them. */
tob = to.toBasetype().isTypeBasic();
if (tob)
return implicitConvTo(tob);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibuclaw These two lines caused regression https://issues.dlang.org/show_bug.cgi?id=19499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants