Skip to content

Fix Issue 19415 - return non-copyable struct fails if member function has return attribute #8983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
Nov 22, 2018
Merged

Fix Issue 19415 - return non-copyable struct fails if member function has return attribute #8983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/dmd/mtype.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5506,7 +5506,9 @@ extern (C++) final class TypeStruct : Type
// Probably should cache this information in sym rather than recompute
StructDeclaration s = sym;

sym.size(Loc.initial); // give error for forward references
if (sym.members && !sym.determineFields() && sym.type != Type.terror)
error(sym.loc, "no size because of forward references");

foreach (VarDeclaration v; s.fields)
{
if (v.storage_class & STC.ref_ || v.hasPointers())
Expand Down
14 changes: 14 additions & 0 deletions test/compilable/test19145.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// https://issues.dlang.org/show_bug.cgi?id=19415

struct S
{
int x;
S foo() return { return S(x); }
this(this) @disable;
}

S bar()
{
S s;
return s; // Error: struct `S` is not copyable because it is annotated with @disable
}