Skip to content

Modify sanitize_json.d to support new runtime directory object_#9049

Merged
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:object_lifetime
Dec 9, 2018
Merged

Modify sanitize_json.d to support new runtime directory object_#9049
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:object_lifetime

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Dec 9, 2018

Required for dlang/druntime#2399 to pass the test suite.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9049"

@wilzbach
Copy link
Contributor

wilzbach commented Dec 9, 2018

Can we please not merge stuff with only a 1 hour waiting period?

In this case, moving things into core should be the way to go instead of creating a new top-level package...

@wilzbach
Copy link
Contributor

wilzbach commented Dec 9, 2018

Revert: #9052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants