Fix Issue 19014 - Compiler imports symbols that aren't actually imported#9050
Merged
dlang-bot merged 1 commit intodlang:masterfrom Dec 9, 2018
JinShil:fix_19014
Merged
Fix Issue 19014 - Compiler imports symbols that aren't actually imported#9050dlang-bot merged 1 commit intodlang:masterfrom JinShil:fix_19014
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:fix_19014
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9050" |
thewilsonator
approved these changes
Dec 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to verify fix for https://issues.dlang.org/show_bug.cgi?id=19014 When this is pulled the bug can be closed.
@braddr The fix will be released with 2.084? Any chance we can get the autotester updated with 2.084 at that time. This bug is holding up dlang/druntime#2399