Skip to content

Fix Issue 19014 - Compiler imports symbols that aren't actually imported#9050

Merged
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:fix_19014
Dec 9, 2018
Merged

Fix Issue 19014 - Compiler imports symbols that aren't actually imported#9050
dlang-bot merged 1 commit intodlang:masterfrom
JinShil:fix_19014

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Dec 9, 2018

Adds a test to verify fix for https://issues.dlang.org/show_bug.cgi?id=19014 When this is pulled the bug can be closed.

@braddr The fix will be released with 2.084? Any chance we can get the autotester updated with 2.084 at that time. This bug is holding up dlang/druntime#2399

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19014 normal Compiler imports symbols that aren't actually imported.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9050"

@dlang-bot dlang-bot merged commit 3d86635 into dlang:master Dec 9, 2018
@JinShil JinShil deleted the fix_19014 branch December 9, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants