dmd.root.filename: Define PATH_MAX if missing in druntime#9382
Merged
dlang-bot merged 1 commit intodlang:stablefrom Feb 23, 2019
Merged
dmd.root.filename: Define PATH_MAX if missing in druntime#9382dlang-bot merged 1 commit intodlang:stablefrom
dlang-bot merged 1 commit intodlang:stablefrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9382" |
thewilsonator
approved these changes
Feb 23, 2019
Contributor
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
Should this go to stable?
Contributor
Yes, #9261 is in stable. |
jacob-carlborg
approved these changes
Feb 23, 2019
|
This appears to have fixed Issue 19684: "DMD 2.085.0-beta.1: DMD cannot find dmd.conf if invoked via symlink (OSX)". I tested this by downloading the updated 2.085-beta and the issue no longer surfaces. Closing the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If #9261 introduced a regression, this would squash it (though dmd should really fix their release process).