Skip to content

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Jun 7, 2019

This PR is in support of dlang/druntime#2634

That PR publicly imports a couple of modules from druntime's rt directory into object.d. It causes the test https://github.com/dlang/dmd/blob/master/test/compilable/json2.d to fail because it adds those modules to the json output, but the sanitize_json.d tool has not been programmed to eliminate the rt directory like it has for std, core, and etc. See https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3659831&isPull=true

This PR adds rt to the list of directories to omit in the santitize_json.d tool.

This PR is required for dlang/druntime#2634 to pass the test suite.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9992"

@JinShil JinShil changed the title Remove druntime's rt directory in test/tools/sanitize_json.d Add druntime's rt directory to the list of directories to omit in the test/tools/sanitize_json.d Jun 7, 2019
@dlang-bot dlang-bot merged commit 067c66b into dlang:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants