Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Make Coverage checking more stable#1625

Merged
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:more_stable_circleci
Aug 7, 2016
Merged

Make Coverage checking more stable#1625
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:more_stable_circleci

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Aug 7, 2016

After @MartinNowak's nice work at dlang/dmd#6022, here's a similar setup for Druntime.

Short summary

  • Travis clogs our PR queue -> use CircleCi for coverage testing
  • The coverage testing script now allows to run for 64-bit & 32-bit (a run takes only 3 minutes, so I think we can enable here two containers too)
  • moved style check to the posix.mak as style target

@wilzbach wilzbach force-pushed the more_stable_circleci branch from 79c3f69 to 41baf18 Compare August 7, 2016 17:41
@dnadlinger
Copy link
Contributor

Leaving for @MartinNowak to greenlight,but should be okay.

@wilzbach wilzbach force-pushed the more_stable_circleci branch from 41baf18 to d929801 Compare August 7, 2016 17:56
@wilzbach wilzbach force-pushed the more_stable_circleci branch from d929801 to 4784c7d Compare August 7, 2016 18:01
@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 7, 2016

moved style check to the posix.mak as style target

Oh sorry ... checkwhitespace was already a defined target in the Makefile, so I changed to style require it. style will be used for a similar PR at Phobos, s.t. we have clear naming and the style target at druntime could/should be expanded anyhow ;-)

@MartinNowak
Copy link
Member

Auto-merge toggled on

@MartinNowak MartinNowak merged commit 111d06c into dlang:master Aug 7, 2016
@wilzbach wilzbach deleted the more_stable_circleci branch August 7, 2016 23:20
@MartinNowak
Copy link
Member

Can we also please enable CircleCI for druntime and Phobos @WalterBright @andralex.
https://circleci.com/add-projects

@andralex
Copy link
Member

@MartinNowak are we good now?

@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 12, 2016

@MartinNowak are we good now?

Yep we are all set & all projects are enabled, only the configuration for Phobos is pending
See it in "live" e.g here:

#1602

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants