Turn the SECURITY_ enum into a uint.#1732
Turn the SECURITY_ enum into a uint.#1732braddr merged 1 commit intodlang:masterfrom LemonBoy:bool-conv
Conversation
It's always being used in bitwise operations anyway and the initializers for it were integers.
|
For reference: https://en.m.wikipedia.org/wiki/HRESULT |
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Looks reasonably to me as well.
|
It looks like the continuous integration build is failing for some reason. |
|
@LemonBoy you need to rebase this, then the jenkins test should pass. I had the same issue. I think this will work, but not 100% sure, I always have to look it up: |
|
Wow, this is such a simple change. May be better to just make a new PR... |
@schveiguy as Jenkins was disabled for DMD and Phobos, I just disabled it here as well. Ideally now closing & reopening the PR should work. |
|
Manually merging due to having long ago exceeded the max number of status updates (1000) a single context can provide. A direct side effect of a prioritized build that isn't being merged. |
|
Manually merging due to exceeding 1000 status updates due to being prioritized for a month without being merged. |
6 participants
Instead of turning the initializers into
true/falseI've just changed its type touint, the values are usually used in bitwise operations and it makes not much sense to keep those asbool. I think.