This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 17375: Use OPTIONAL_PIC in the test suite #1863
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test suite didn't compile the executable with fPIC or with -cov no
matter if that was set in the top makefile (since it is a) overriding
DFLAGS, and b) because OPTIONAL_PIC was not exported from the main make
file to sub make files).
This makes test suite compile executables with the fPIC if requested
with PIC. Incidentally, this fixes a problem compiling shared test suite
on arch linux with binutils greater than v2.28, since the executable
itself will be compiled with -fPIC, not just shared library.
N.B.: the -cov flag is present, but not exported and used, because
some shared library tests are segfaulting when compiled with -cov.