Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@Burgos
Copy link
Contributor

@Burgos Burgos commented Jul 9, 2017

Test suite didn't compile the executable with fPIC or with -cov no
matter if that was set in the top makefile (since it is a) overriding
DFLAGS, and b) because OPTIONAL_PIC was not exported from the main make
file to sub make files).

This makes test suite compile executables with the fPIC if requested
with PIC. Incidentally, this fixes a problem compiling shared test suite
on arch linux with binutils greater than v2.28, since the executable
itself will be compiled with -fPIC, not just shared library.

N.B.: the -cov flag is present, but not exported and used, because
some shared library tests are segfaulting when compiled with -cov.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 9, 2017

Thanks for your pull request, @Burgos! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17375 colliding modules detected with binutils 2.28 linker and shared libraries

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jul 9, 2017
Test suite didn't compile the executable with fPIC or with -cov no
matter if that was set in the top makefile (since it is a) overriding
DFLAGS, and b) because OPTIONAL_PIC was not exported from the main make
file to sub make files).

This makes test suite compile executables with the fPIC if requested
with PIC. Incidentally, this fixes a problem compiling shared test suite
on arch linux with binutils greater than v2.28 (see issue 17375), since
the executable itself will be compiled with -fPIC, not just shared
library.

N.B.: the -cov flag is present, but not exported and used, because
some shared library tests are segfaulting when compiled with -cov.
@Burgos
Copy link
Contributor Author

Burgos commented Jul 9, 2017

Edit: removed "Fix issue" annotation, since it just worksaround it so that testsuite may work.

@Burgos
Copy link
Contributor Author

Burgos commented Jul 9, 2017

Added -dip1000 flag to test-suite while I was there as well.

@Burgos
Copy link
Contributor Author

Burgos commented Jul 9, 2017

Bah, now I found out #1721 which is staled from December. :grumpy_cat:. Closing as duplicate, will reopen a new one with the -dip1000 now.

@Burgos Burgos closed this Jul 9, 2017
@Burgos Burgos deleted the pass-pic branch July 9, 2017 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants