This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Disable Codecov status messages#1874
Merged
dlang-bot merged 2 commits intodlang:masterfrom Jul 16, 2017
Merged
Conversation
Due to many random coverage changes, the current CodeCov is suboptimal at Druntime as it triggers many red crosses for perfectly healthy PRs. As there's no way to configure CodeCov nor GitHub to change the behavior to _not_ showing an overall failed status for coverage failures, the simple solution is to turn the CodeCov status notifications off. However, in the future the Dlang-Bot might display the CodeCov summary as part of his comment. Furthermore, the CodeCov commits will continue to get logged at [1], a summary coverage for each file on e.g. master can always be found at [2] and the CodeCov browser extension [3] will be working as well. [1] https://codecov.io/gh/dlang/druntime [2] https://codecov.io/gh/dlang/druntime/list/master [3] https://github.com/codecov/browser-extension
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
CyberShadow
approved these changes
Jul 16, 2017
wilzbach
force-pushed
the
disable-codecov
branch
from
78b5f36 to
2945c19
Compare
Contributor
Author
|
(rebased to rekick DAutoTest) @CyberShadow FYI: I added a simple dumping |
Member
|
Alright :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to many random coverage changes, the current CodeCov is suboptimal
at Druntime as it triggers many red crosses for perfectly healthy PRs.
As there's no way to configure CodeCov nor GitHub to change the
behavior to not showing an overall failed status for coverage failures,
the simple solution is to turn the CodeCov status notifications off.
However, in the future the Dlang-Bot might display the CodeCov summary
as part of his comment.
Furthermore, the CodeCov commits will continue to get logged at [1], a
summary coverage for each file on e.g. master can always be found at [2] and
the CodeCov browser extension [3] will be working as well.
[1] https://codecov.io/gh/dlang/druntime
[2] https://codecov.io/gh/dlang/druntime/list/master
[3] https://github.com/codecov/browser-extension