profile test: allow both the old and the new mangling#1878
profile test: allow both the old and the new mangling#1878dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
test/profile/Makefile
Outdated
| $(QUIET)$(GREP) -q '1 .*_Dmain' $(ROOT)/both.log | ||
| $(QUIET)$(GREP) -q '1000 .*both.Num\* both.foo(uint)' $(ROOT)/both.log | ||
| $(QUIET)$(DIFF) both.def.exp $(ROOT)/both.def | ||
| $(QUIET)$(DIFF) both.def.exp $(ROOT)/both.def || $(DIFF) both.def.exp2 $(ROOT)/both.def |
There was a problem hiding this comment.
Maybe adding a new comment that this allows the old & new mangling and can be removed in the future wouldn't hurt?
| @@ -0,0 +1,5 @@ | |||
|
|
|||
| FUNCTIONS | |||
| _Dmain | |||
There was a problem hiding this comment.
You have tabs here ... (you need to either replace them or make the check more specific)..
There was a problem hiding this comment.
Those tabs are generated as part of the profile output and are also in both.exp.
There was a problem hiding this comment.
I know - I was just FYIing the CI error.
I didn't add the whitespace check here, but it seems that .exp files are explicitly filtered out. So the simple fix is to rename the file ...
There was a problem hiding this comment.
Sorry, misunderstood at first. Renamed now.
rainers
force-pushed
the
fix_profile_mangle_test
branch
from
cd1122c to
43d953f
Compare
rainers
force-pushed
the
fix_profile_mangle_test
branch
from
43d953f to
e80a739
Compare
3 participants
needed for dlang/dmd#6998