Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Fix DMD path to ../generated#1978

Merged
braddr merged 1 commit intodlang:masterfrom
wilzbach:fix-dmd-path
Nov 29, 2017
Merged

Fix DMD path to ../generated#1978
braddr merged 1 commit intodlang:masterfrom
wilzbach:fix-dmd-path

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Nov 28, 2017

So I'm trying to move ahead with the ddmd -> dmd transition (dlang/dmd#7135) and due to braddr/at-client#4 we are stuck at the moment.

Hence, this PR tries to set the DMD binary path by default to one in the generated directory. As I have no Windows machine, I'm doing this more or less blindly, but it looks trivial enough.

See also: dlang/phobos#5892

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@PetarKirov
Copy link
Member

The Win_32_64 build failed with:

Error on line 6: expecting target : dependencies

which doesn't make sense to me. On the other hand, the phobos build went without a hitch, so the problem may go away.

@rainers
Copy link
Member

rainers commented Nov 28, 2017

Error on line 6: expecting target : dependencies

That's usually the error message that appears when patching the makefiles by the autotester fails. @braddr, please remove that.

@braddr braddr merged commit 32c4354 into dlang:master Nov 29, 2017
@wilzbach wilzbach deleted the fix-dmd-path branch November 29, 2017 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants