Halt on Ddoc errors & fix the existing ones#1993
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
posix.mak
Outdated
|
|
||
| $(DOCDIR)/object.html : src/object.d | ||
| $(DMD) $(DDOCFLAGS) -Df$@ project.ddoc $(DOCFMT) $< | ||
| $(DMD) $(DDOCFLAGS) -Df$@ project.ddoc $(DOCFMT) $< 2>&1 | grep "Warning:"; test $$? -eq 1 |
There was a problem hiding this comment.
I think all you need to set the error level is grep -v "Warning:".
There was a problem hiding this comment.
Also a problem with this pattern is that if dmd fails with no warning the command will succeed.
|
Okay I removed the explicit grepping for error messages and rebased the PR to just contain the Ddoc fix so that it's absolutely non-controversial and we can move on with this, because once this is merged we can merge the dlang/dmd#7440 at DMD and then |
Required for dlang/dmd#7440