This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Merge remote-tracking branch 'upstream/stable' into merge_stable #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be read (edit) src/rt isn't shipped with druntime's imports, so it can't be imported directly from core.runtime. This PR fixes importing rt.config from a public druntime module by replacing it with an extern definition. To reproduce the bug create a file that imports 'core.runtime' and compile it with: dmd -unittest -deps filename.d The error is: /usr/include/dmd/druntime/import/core/runtime.d(653): Error: module config is in file 'rt/config.d' which cannot be read
Fix import from rt.config merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
MartinNowak
requested review from
Burgos,
PetarKirov,
andralex and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla references
|
wilzbach
approved these changes
Jan 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.