This repository was archived by the owner on Oct 12, 2022. It is now read-only.
zero class storage when initializer is null #2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2091" |
MartinNowak
requested review from
schveiguy
and removed request for
Burgos and
PetarKirov
Member
Do we even need the null check then? That was part of my point also. In any case, this is at least more correct. |
schveiguy
approved these changes
Feb 13, 2018
PetarKirov
approved these changes
Feb 20, 2018
PetarKirov
reviewed
Feb 20, 2018
thewilsonator
force-pushed
the
fixup2079
branch
from
be7f667 to
2369b9f
Compare
thewilsonator
approved these changes
Jan 4, 2019
- all zero initializers are not stored in the typeinfo although classes currently always come with a non-zero vtable
thewilsonator
force-pushed
the
fixup2079
branch
from
2369b9f to
da6ab01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classes currently always come with a non-zero vtable
fixup for #2079