Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

fix issue 18536 - Bad stack traces when building with -m32mscoff#2119

Merged
dlang-bot merged 1 commit intodlang:masterfrom
rainers:issue18536
Feb 28, 2018
Merged

fix issue 18536 - Bad stack traces when building with -m32mscoff#2119
dlang-bot merged 1 commit intodlang:masterfrom
rainers:issue18536

Conversation

@rainers
Copy link
Member

@rainers rainers commented Feb 28, 2018

dmdDecodeString is harmful for non-mangled names, disable it for anything but OMF

dmdDecodeString is harmful for non-mangled names, disable it for anything but OMF
@rainers rainers requested a review from CyberShadow as a code owner February 28, 2018 09:44
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
18536 normal Bad stack traces when building with -m32mscoff

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Feb 28, 2018
@wilzbach
Copy link
Contributor

@rainers is there a chance to add a test for this, s.t. it doesn't regress?
Maybe something similar to https://github.com/dlang/druntime/blob/master/test/exceptions/Makefile, but for Windows?

@rainers
Copy link
Member Author

rainers commented Feb 28, 2018

It would have been caught if we'd run the dmd test suite for -m32mscoff, too. Maybe AppVeyor should be switched to that platform instead of Win64 which is already covered by the auto tester.

@wilzbach
Copy link
Contributor

It would have been caught if we'd run the dmd test suite for -m32mscoff, too. Maybe AppVeyor should be switched to that platform instead of Win64 which is already covered by the auto tester.

Can't we run both? At the the average build time is ~18 minutes which isn't great, but still has some leeway for more.

@dlang-bot dlang-bot merged commit 4d6650c into dlang:master Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants