This repository was archived by the owner on Oct 12, 2022. It is now read-only.
fix issue 18536 - Bad stack traces when building with -m32mscoff#2119
Merged
dlang-bot merged 1 commit intodlang:masterfrom Feb 28, 2018
Merged
fix issue 18536 - Bad stack traces when building with -m32mscoff#2119dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
dmdDecodeString is harmful for non-mangled names, disable it for anything but OMF
Contributor
PetarKirov
approved these changes
Feb 28, 2018
Contributor
|
@rainers is there a chance to add a test for this, s.t. it doesn't regress? |
Member
Author
|
It would have been caught if we'd run the dmd test suite for -m32mscoff, too. Maybe AppVeyor should be switched to that platform instead of Win64 which is already covered by the auto tester. |
Contributor
Can't we run both? At the the average build time is ~18 minutes which isn't great, but still has some leeway for more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmdDecodeString is harmful for non-mangled names, disable it for anything but OMF