This repository was archived by the owner on Oct 12, 2022. It is now read-only.
add scope to abort() #2149
Merged
add scope to abort() #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2149" |
JinShil
approved these changes
Mar 23, 2018
schveiguy
approved these changes
Mar 23, 2018
src/core/internal/abort.d
Outdated
| * code, and druntime is -release compiled. | ||
| */ | ||
| void abort(string msg, string filename = __FILE__, size_t line = __LINE__) @nogc nothrow @safe | ||
| void abort(scope string msg, string filename = __FILE__, size_t line = __LINE__) @nogc nothrow @safe |
Member
There was a problem hiding this comment.
Why not scope on the filename parameter? True most of the time you use the default, but if you didn't want to, then this makes it slightly more difficult.
Contributor
|
Windows failure is unrelated -> braddr/d-tester#71 |
Contributor
|
Same for the dlang/ci one -> dlang/ci#189 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.