std::string_view posix tests

[TurkeyMan]

No description provided.

[dlang-bot]

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2347"

[TurkeyMan]

I don't run these systems... if people can help me get these across the line, that'd be real great!

[jacob-carlborg]

I don't run these systems... if people can help me get these across the line, that'd be real great!

You need to start 😉.

[thewilsonator]

I remember something similar to that output not too long ago, can I suggest you rebase? If nothing else it will rule that out.

[TurkeyMan]

I don't run these systems... if people can help me get these across the line, that'd be real great!

You need to start 😉.

I would see Apple burn before I infect any piece of hardware in my presence! ;)

[jacob-carlborg]

I would see Apple burn before I infect any piece of hardware in my presence! ;)

The PR title says "posix". There are other Posix systems than those created by Apple 😉.

Beside the smiley I added above, it would gain you a lot to test on non Windows platforms locally. To avoid having to wait for the CI systems to pass or for someone else to fix your PR.

[TurkeyMan]

I would see Apple burn before I infect any piece of hardware in my presence! ;)

The PR title says "posix". There are other Posix systems than those created by Apple 😉.

True, but Apple has caused the the most trouble, with having a slightly weird ecosystem; gotta explicitly request to link the C++ runtime (even when supplying -std=, that whole std::__1 thing, 32bit darwin not working, etc.

Beside the smiley I added above, it would gain you a lot to test on non Windows platforms locally. To avoid having to wait for the CI systems to pass or for someone else to fix your PR.

I mean, I could just stop doing this altogether... I'm not getting anything at all for my time from this at this point! My stuff already works fine.

[atilaneves]

Tests are broken due to -std=c++17 - whatever gcc version is on the autotester, it's too old. Unfortunately, and unlike Travis, it's impossible AFAIK to install anything on the autotester machines.

[wilzbach]

Tests are broken due to -std=c++17 - whatever gcc version is on the autotester, it's too old. Unfortunately, and unlike Travis, it's impossible AFAIK to install anything on the autotester machines.

You could just not run the test for older compilers (or on the auto-tester). Since a few days, buildkite runs the full druntime test suite too (see e.g. dlang/ci#301)

[wilzbach]

it's impossible AFAIK to install anything on the autotester machines.

Alternatively you could always ping @braddr to upgrade the compilers on these machines or ping him here https://github.com/braddr/d-tester/issues.