This repository was archived by the owner on Oct 12, 2022. It is now read-only.
rt.sections_elf_shared: Fix struct tls_index definition on x32 #2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2354" |
n8sh
reviewed
Nov 17, 2018
| else | ||
| { | ||
| c_ulong ti_module; | ||
| c_ulong ti_offset; |
Member
There was a problem hiding this comment.
I've verified that in other cases ti_module & ti_offset are unsigned long int.
Member
Author
There was a problem hiding this comment.
Oh, just for the discussion thread, I left size_t in as the default branch. At least musl defines this as a size_t[2] type.
(Grep'ing musl 1.16 for __tls__get_addr):
void *__tls_get_addr(size_t *);
...
return __tls_get_addr((size_t []){def.dso->tls_id, def.sym->st_value});
Member
There was a problem hiding this comment.
By "other cases" I meant only by grepping the source of glibc. I didn't mean for musl etc.
n8sh
approved these changes
Nov 17, 2018
chunorig
pushed a commit
to chunorig/gcc-kludges
that referenced
this pull request
Jan 26, 2019
Commits merged from druntime.
Fix struct tls_index definition on x32
dlang/druntime#2354
Update SectionGroup signatures to match on all targets
dlang/druntime#2401
Fix issue 19128 - argument to alloca may be too large
dlang/druntime#2409
Define some common filesystem limits in core.stdc.limits
dlang/druntime#2460
Use version Darwin instead of OSX in core.sys.posix.aio
dlang/druntime#2470
Commits merged from phobos.
Don't run HardFloat tests on SoftFloat systems
dlang/phobos#5358
Remove reliance on stdin, stdout, stderr being aliasable
dlang/phobos#5718
Solaris: add import clock_gettime to currStdTime
dlang/phobos#5807
Don't print debug messages when building unittests
dlang/phobos#6827
Add HPPA support to phobos
Fixes https://gcc.gnu.org/PR89054
dlang/phobos#6836
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268293 138bc75d-0d04-0410-961f-82ee72b054a4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running all druntime unittests, this is the only place where an X32 regression was found, the effect seen was that live TLS data was being collected and freed at runtime.