Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jan 20, 2019

Bindings are HPPA support, and some work towards OSX.

Backport of core.internal.hash is a primer for another PR that will fix hashing of complex reals.

@ibuclaw ibuclaw added the Trivial typos, formatting, comments label Jan 20, 2019
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + druntime#2469"

@PetarKirov
Copy link
Member

@ibuclaw the only commit that I have doubts for is 0cbe48d. What was your process in making it, as I guess it encompasses tens of commits from the master branch.

@ibuclaw
Copy link
Member Author

ibuclaw commented Jan 21, 2019

@ZombineDev - meld mostly.

The ultimate patch is it intended for is #2356 fix to apply cleanly and work.

The original patch sent to me on gcc mailing list had the minimum required backported in order to use it in core.internal.hash, I suggested that instead all PRs leading up to should be backported in order to simplify transition from dmd-cxx to master (the minimum changes were already non-trivial anyway).

Pretty much its all the work of @n8sh squashed into one. There are only a couple omissions that depended on newer compiler features. Nothing that was a regression anyway.

To give a small list of PRs I looked at (just copied from my mail response):

2197, 2202, 2210, 2200, 2227, 2209,
2198, 2243, 2240, 2246, 2311

There are many more, and I'm not going to apply them individually. :-)

@PetarKirov
Copy link
Member

Alright, thanks for the info!

@PetarKirov PetarKirov merged commit 2c785eb into dlang:dmd-cxx Jan 21, 2019
@ibuclaw ibuclaw deleted the dmd-cxx-backports branch January 21, 2019 15:35
kraj pushed a commit to kraj/gcc that referenced this pull request Feb 11, 2019
Backported from upstream druntime 2.084

Reviewed-on: dlang/druntime#2469

libphobos/ChangeLog:

	* libdruntime/Makefile.am (DRUNTIME_DSOURCES): Remove rt/util/hash.d
	* libdruntime/Makefile.in: Rebuild.
	* testsuite/libphobos.aa/aa.exp: New file.
	* testsuite/libphobos.aa/test_aa.d: New test.
	* testsuite/libphobos.hash/hash.exp: New file.
	* testsuite/libphobos.hash/test_hash.d: New test.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268754 138bc75d-0d04-0410-961f-82ee72b054a4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants