Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Fix implicit cast issue in stdcpp.array#2529

Merged
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:patch
Mar 29, 2019
Merged

Fix implicit cast issue in stdcpp.array#2529
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:patch

Conversation

@RazvanN7
Copy link
Contributor

Due to a bug in dmd, there was an implicit cast inserted by the compiler. This is currently blocking [1]. For more information check [1]

[1] dlang/dmd#9505

@RazvanN7 RazvanN7 requested a review from WalterBright as a code owner March 29, 2019 11:03
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2529"

@dlang-bot dlang-bot merged commit 26935eb into dlang:master Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants