This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Move _d_arraysetlengthT* into a template to always instantiate both#2667
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 8, 2019
Merged
Move _d_arraysetlengthT* into a template to always instantiate both#2667dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>
Contributor
|
Thanks for your pull request and interest in making D better, @Vild! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2667" |
JinShil
approved these changes
Jul 7, 2019
thewilsonator
approved these changes
Jul 8, 2019
This was referenced Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two problem that happens when trying to apply dlang/dmd#10106.
Firstly, it marks the hooks with
pragma(inline, false)to not break thedmd/dinterpret.dctfe interception code.Secondly, it wraps both of the hooks inside of a template to force the compiler to create an instance of both function for every type that is used.
This fixes a undefined reference problem that can will happen when
Appenderfrom phobos is used with-profile=gc. The linker complains about a missing_d_arraysetlengthTTrace!Tarrinstance, as phobos only had the_d_arraysetlengthT!Tarrinstance compiled in its library, and not the_d_arraysetlengthTTrace!Tarrinstance. By forcing both hooks to be always be instantiated, this problem will not happen.