Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 19, 2019

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 19, 2019

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + druntime#2743"

@andralex
Copy link
Member

I'm all for this. @atilaneves ?

Copy link
Member

@rainers rainers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if you want this in 2.088, you'll have to target stable.

@JinShil JinShil changed the base branch from master to stable August 19, 2019 06:37
@JinShil
Copy link
Contributor Author

JinShil commented Aug 19, 2019

Now targeting stable

@thewilsonator
Copy link
Contributor

I'm assuming that the build kite phobos failure is bogus given that the autotester passes.

@thewilsonator thewilsonator merged commit 52881f5 into dlang:stable Aug 19, 2019
@JinShil JinShil deleted the deprecate_callStrucDtorsDuringGC branch August 19, 2019 10:25
@atilaneves
Copy link
Contributor

I was going to say "fine by me as well" but it's already been merged anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants