-
-
Notifications
You must be signed in to change notification settings - Fork 411
Move array dup properties from object.d to core.internal #2761
Conversation
|
Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2761" |
|
Weird! All packages in buildkite pass, but the unittests in |
|
|
@thewilsonator. Thanks. I see the error message, but any idea why it is occurring? All I did was move the code. |
|
Dunno, but it seems that all of those should be |
Line 38 explicitly says |
|
IDK, try asking on slack or the NG, |
|
I don't think these symbols should be in |
Followup to #2647, #2644, #2643, and #2634
This is a continuation of work to clean up object.d. It's just a cut-and-paste with the exception of
getPostblitanddoPostblitwhich were made public (though still private to druntime because it is incore.internal) so it could be used by some associative array code that still resides in object.d