This repository was archived by the owner on Oct 12, 2022. It is now read-only.
core.math: Re-enable disabled tests and update toPrec comment#2871
Merged
ibuclaw merged 4 commits intodlang:stablefrom Apr 27, 2020
ibuclaw:toprectest
Merged
core.math: Re-enable disabled tests and update toPrec comment#2871ibuclaw merged 4 commits intodlang:stablefrom ibuclaw:toprectest
ibuclaw merged 4 commits intodlang:stablefrom
ibuclaw:toprectest
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#2871" |
thewilsonator
approved these changes
Dec 30, 2019
Contributor
|
Whats the status of this? |
Member
Author
|
One small blocker in dlang/dmd#11026, ready for merge once that fix is in the compiler. |
Member
Author
|
@thewilsonator - Rebased, hopefully it'll pass now. |
Member
Author
|
But of course there's got to be some weird law that says assertions work when tested outside the module, but the same tests fail inside. |
ibuclaw
requested review from
DmitryOlshansky,
Geod24,
MartinNowak,
WalterBright,
andralex,
rainers,
schveiguy and
wilzbach
as code owners
ibuclaw
requested review from
Burgos,
CyberShadow,
jacob-carlborg and
jmdavis
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This to follow the merge of dlang/dmd#10654.