Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@alexandrumc
Copy link
Contributor

Please see #2888

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @alexandrumc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2893"

@alexandrumc alexandrumc closed this Jan 3, 2020
@alexandrumc alexandrumc reopened this Jan 3, 2020
@alexandrumc alexandrumc closed this Jan 3, 2020
@alexandrumc alexandrumc deleted the version-remv branch January 3, 2020 11:43
version (unittest)
@betterC @safe pure nothrow unittest
{
void testXCHG(T)(T val) pure nothrow @nogc @trusted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the old behaviour (ditto for other functions, structs, classes)

Suggested change
void testXCHG(T)(T val) pure nothrow @nogc @trusted
static void testXCHG(T)(T val) pure nothrow @nogc @trusted

}

@betterC @safe pure nothrow unittest
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep these blocks to signify that they different tests?
(Bonus: That would imply a much smaller diff and does not screw with the line history)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants