Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

win**.mak: Use explicit path when running unittests#3231

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:debugging-make
Oct 11, 2020
Merged

win**.mak: Use explicit path when running unittests#3231
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:debugging-make

Conversation

@MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Oct 10, 2020

Windows shells might not consider local files when not using an explicit path (unittest).


Maybe this will solve the reoccurring Azure issue.

Windows shells might not consider local files when not using an explicit
path (`unittest`)
@kinke
Copy link
Contributor

kinke commented Oct 10, 2020

Looks like it does...

@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review October 10, 2020 22:25
@Geod24
Copy link
Member

Geod24 commented Oct 11, 2020

Indeed: dlang/dmd#11850 (comment)

@rainers
Copy link
Member

rainers commented Oct 11, 2020

Maybe this will solve the reoccurring Azure issue.

AFAICT this will at least report sensible error codes from unittest crashes. See dlang/dmd#11850 (comment)
druntime doesn't test the same azure configurations as dmd, namely also not the one using mingw based libraries.

@dlang-bot dlang-bot merged commit 5642a9e into dlang:master Oct 11, 2020
@WalterBright
Copy link
Member

@rainers > AFAICT this will at least report sensible error codes from unittest crashes. See dlang/dmd#11850 (comment)
druntime doesn't test the same azure configurations as dmd, namely also not the one using mingw based libraries.

Azure is still failing the same way. dlang/dmd#11846

@Geod24
Copy link
Member

Geod24 commented Oct 11, 2020

@WalterBright : Not the same. Now we get an error code (the exe crash) instead of a cryptic "executable not found".
But yes, the underlying issue is still here and needs to be fixed.

@MoonlightSentinel MoonlightSentinel deleted the debugging-make branch June 22, 2021 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants