dwarf.d: remove spurious trailing comma#3498
dwarf.d: remove spurious trailing comma#3498WalterBright wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3498" |
What the heck? That has nothing to do with this trivial PR. |
|
It's not a bug, it's a feature. |
|
If it's used exactly once, it's not much of a feature. |
|
More uses here: dlang/dmd#12684 (comment) |
|
This might be bad style for just two arguments, but as noted this is a feature not a bug. |
How many commits between |
Geod24
left a comment
There was a problem hiding this comment.
Not an oversight, very much on purpose, as there is another usage of it in the commit that introduced it:
f653441#diff-1b94c982760aac40515b2b539895bf36e83f45159711f983f09290277a996587R91-R96
And we established it's not a bug, but a feature introduced 10 years ago as a fix to issue 2477.
|
FWMOIW (For Whatever My Opinion Is Worth): This feature makes it easier to write some code-generating ( Also: If code is indented like this: then that trailing comma ensures we can add I love this bug^H^H^Hfeature. Therefore, I vote against removing code which (even accidentally) exploits the feature. Otherwise, others (including @WalterBright) might remove the ahem bug and actually get away with it ! |
|
The DMD PR has been closed, so closing this too. |
Bad style exploiting what appears to be a bug in the D front end.