This repository was archived by the owner on Oct 12, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 420
Fix Issue 22218 - Dynamic casts across binary boundaries can easily fail #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3543" |
kinke
commented
Aug 16, 2021
src/rt/cast_.d
Outdated
{ | ||
if (a is b) | ||
return true; | ||
return (a && b) && a.name == b.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure
whether the null-checks are really required here, or are better moved to the few call sites potentially passing a null,(edit: moved)- whether the extra name check should be restricted to shared druntime (
*.{so,dll}
) only, in order not to slow down dynamic casts with static druntime, assuming static druntime isn't used for multiple D binaries in a process (with Windows exception for DMD) - see Fix exceptions and dynamic casts across dll boundaries #2828 (comment).
Actually fixed by the previous commits, just fixing up the rt.cast_ compile errors after the rebase.
…iccast.d directly
EH across DLLs needs more work with DMD on Win64, see dlang#2874.
RazvanN7
approved these changes
Aug 17, 2021
This was referenced Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rebase/reboot of #2828.