This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Revert "TypeInfo_Class: Make 2 superfluously virtual functions final"#3546
Closed
Revert "TypeInfo_Class: Make 2 superfluously virtual functions final"#3546
Conversation
This reverts commit 099b414.
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3546" |
This was referenced Aug 17, 2021
RazvanN7
approved these changes
Aug 17, 2021
Member
Author
|
Hmm, I could reproduce success in the terminal for dmd/fbsd11, but not druntime. Will dig a little more further to find out why. |
Member
Author
|
I'm just going to close this and adjust the dmd test (again). However the issue that dmd attempted to fix should really be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3544
FreeBSD 11.4 pipelines are failing in master since this change.
https://cirrus-ci.com/task/4605506372239360
There seems to be neither rhyme nor reason why this change in particular affects the test, however its one of those ones where binary size and environmental variables come into play.