-
-
Notifications
You must be signed in to change notification settings - Fork 420
Fix issue 18063 - thread_attachThis returns dangling pointer #3579
Conversation
Thanks for your pull request and interest in making D better, @Temtaime! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3579" |
@acehreli Thanks for your work, but |
I worked on this PR without any prior experience with druntime after hitting similar or the same issues as you did. :) It is very likely that it's not complete. In fact, it used to fail the OSX 32-bit tests, which were special because thread-local storage was implemented (reportedly) manually there. |
I should add: The OSX 32-bit support has since been dropped, so I was hoping that the PR is in better shape but apparently not. :/ |
Rebase of #1989