Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Add template _d_delstructTrace#3644

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
teodutu:template-_d_delstructTrace
Dec 10, 2021
Merged

Add template _d_delstructTrace#3644
RazvanN7 merged 1 commit intodlang:masterfrom
teodutu:template-_d_delstructTrace

Conversation

@teodutu
Copy link
Member

@teodutu teodutu commented Dec 9, 2021

This PR changed the lowering of delete expressions from the old hook to a new one that uses templates. The latter PR only implemented _d_delstruct and not _d_delstructTrace. This PR adds _d_delstructTrace as an alias that eventually calls the same _d_delstruct.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3644"

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@teodutu teodutu force-pushed the template-_d_delstructTrace branch from f65efb9 to 12faaf3 Compare December 9, 2021 18:15
@RazvanN7 RazvanN7 merged commit b0bfb63 into dlang:master Dec 10, 2021
teodutu added a commit to teodutu/dmd that referenced this pull request Dec 10, 2021
_d_delstructTrace was added in this PR: dlang/druntime#3644

Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@teodutu teodutu deleted the template-_d_delstructTrace branch December 20, 2021 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants