This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Add explicit _d_arrayappendTTrace hook#3807
Merged
dlang-bot merged 1 commit intodlang:masterfrom Apr 23, 2022
Merged
Conversation
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Contributor
|
Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3807" |
thewilsonator
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I reworked
_d_arrayappendTto a template (#3805), I believed I could recreate_d_arrayappendTTracein the compiler by just instantiating the old alias:_d_HookTraceImpl!(Tarr, _d_arrayappendT, errorMessage);However, this assumption turned out to be incorrect because
_d_HookTraceImplretrieves the types of the hook's parameters usingParameters!Hook. This expression triggered an error whenHookis a template because the types of its parameters weren't inferred yet.The solution I chose was to add an explicit
_d_arrayappendTTracehook that uses a string mixin for the prints. This change is needed by dlang/dmd#13495.