This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Remove previously templated hooks#3826
Merged
thewilsonator merged 1 commit intodlang:masterfrom May 27, 2022
Merged
Conversation
These hooks have been converted to templates and their lowerings changed to use those templates: - dlang/dmd#13116 - dlang/dmd#13495 - dlang/dmd#13398 Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
requested review from
Burgos,
andralex,
rainers,
schveiguy and
wilzbach
as code owners
Contributor
|
Thanks for your pull request and interest in making D better, @teodutu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3826" |
thewilsonator
approved these changes
May 26, 2022
Contributor
|
Vibe failure is unrelated. |
Member
|
This will cause more regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_d_arrayappendT,_d_arrayappend{,set}ctorand_d_delstructwere converted to templates and their lowerings in DMD now use the new template hooks._d_array{,set}ctor:_d_delstruct:_d_arrayappendT:_d_arrayappend{T,cTX}to templates dmd#13495This PR removes the old non-template hooks as they are no longer used.