Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Add FreeBSD header sys/elf.h #586

Merged
merged 1 commit into from
Aug 27, 2013
Merged

Add FreeBSD header sys/elf.h #586

merged 1 commit into from
Aug 27, 2013

Conversation

redstar
Copy link
Contributor

@redstar redstar commented Aug 25, 2013

On FreeBSD, sys/elf.h includes sys/elf-common.h, sys/elf32.h and sys/elf64.h. The content is summarized in one D module.

@MartinNowak
Copy link
Member

Great!
I would prefer though if each header had a one-to-one correspondent D file. Basically the Deimos rules should apply to core..

@MartinNowak
Copy link
Member

You also need to list the added files in mak/MANIFEST and mak/COPY.

@redstar
Copy link
Contributor Author

redstar commented Aug 25, 2013

Ok, then I am going to split the module.

@redstar
Copy link
Contributor Author

redstar commented Aug 25, 2013

Now I have for each header a correspondent D file.

@MartinNowak
Copy link
Member

Looks good.
We still need makefile rules in win32.mak and win64.mak, see here.

Add D modules for sys/elf.h, sys/elf_common.h, sys/elf32.h,
sys/elf64.h and sys/link_elf.h.
@redstar
Copy link
Contributor Author

redstar commented Aug 27, 2013

Thanks for the pointer to the missing makefile entries. I am so used to the CMake system that I really forgot to look at the makefiles.

@alexrp
Copy link
Member

alexrp commented Aug 27, 2013

Seems good to me now. @dawgfoto ?

MartinNowak added a commit that referenced this pull request Aug 27, 2013
Add FreeBSD header sys/elf.h
@MartinNowak MartinNowak merged commit 7ad4524 into dlang:master Aug 27, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants