Fix cubic runtime complexity for collecting source/import files. #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
approved these changes
Feb 23, 2017
| @@ -149,14 +149,14 @@ struct BuildSettings { | |||
| // add string import files (avoids file name duplicates in addition to path duplicates) | |||
| private void addSI(ref string[] arr, in string[] vals) | |||
| { | |||
| outer: | |||
| bool[string] existing; | |||
There was a problem hiding this comment.
A next iteration could cache this as well.
There was a problem hiding this comment.
True, I was a bit afraid to forget a place where it could get out of sync, because the arrays are public fields, so I wanted to leave that to a more in-depth optimization attempt.
|
Okay, since this is just a local change, I'm also pretty confident that it should be without mistakes. I'll rebase and merge after Travis passes, unless any issues come up. |
This is still not very efficient, but now has a finite runtime for large numbers of files.
s-ludwig
force-pushed
the
issue1690_slow_file_collection
branch
from
cbe25ea to
a2e8923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See vibe-d/vibe.d#1690.
This is still not very efficient, doing several temporary allocations and copies, but replaces cubic runtime by almost linear (except for allocation and AA creation times).