Fetch with dependencies

[Panke]

No description provided.

[dlang-bot]

Thanks for your pull request and interest in making D better, @Panke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

[Panke]

I am needing this or something similar for bazel support (#1889)

[Geod24]

Needs a rebase. And for the name, --recursive is more common (e.g. it's what git and many CLI tools use).

[Panke]

Needs a rebase. And for the name, --recursive is more common (e.g. it's what git and many CLI tools use).

--recursive was my first thought, but we got some use of recursive that is quite dissimilar to this one, like #1873 which means sub packages and not dependencies.

I couldn't care less for the name though. If no one else chimes in, it will be recursive.

[Geod24]

I think for dub fetch, --recursive is pretty unambiguous. You cannot fetch sub-packages independently.

[Geod24]

Also need a release notes entry, this is a change that might be interesting to a few people (e.g. in build scripts).

[WebFreak001]

should we make this a switch? imo this should be the default

workflow for someone without internet:

go to internet cafe, connect to internet
fetch all required dependencies
disconnect from internet, go home
build stuff locally -- oops, dependencies of fetched dependencies aren't there by default

[Geod24]

We can't have self-reference / circular reference, can we ? That would be one argument against it.
Having it the default for dub fetch makes sense. IDK about --cache=local though.

[WebFreak001]

definitely needs a test for recursive dependencies here then

[Panke]

We can't have self-reference / circular reference, can we ? That would be one argument against it.
Having it the default for dub fetch makes sense. IDK about --cache=local though.

I don't think --cache=local should be a default. When --recursive becomes the default, what do we call the switch? --shallow? --not-recursive --single --no-dependencies

[Geod24]

I don't think --cache=local should be a default.

Oh I phrased my message very poorly. I meant "IDK if having it the default for cache local makes as much sense". But after reviewing again, I think it does too.

what do we call the switch?

I'd say, in doubt, do what git does. So --shallow.

[Panke]

What we could do is: download everything that is not in the --cache=here. So that afterwards everything is available 'here'

[Panke]

This turns out to be more annoying than I thought. This works only for dependencies that are dependencies of the default configuration, but won't fetch anything for e.g. vibe-d.

I could use some pointers on how to get a list of transitive dependencies.

[WebFreak001]

try checking the selections and/or generating them for the fetched package, they are recursive

[andre2007]

When I execute following commands:

dub fetch vibe-d
dub describe vibe-d

vibe-d and all dependencies are downloaded. Therefore dub describe vibe-d does the fetch with dependencies. Maybe you could check how it works here and reuse the already available functionality?

[andre2007]

Related #1930

[Geod24]

As far as I can tell this was done by #2786