Skip to content

import 'std.variant.Algebraic' properly#2108

Merged
dlang-bot merged 1 commit intodlang:masterfrom
BorisCarvajal:import_Algebraic
Feb 22, 2021
Merged

import 'std.variant.Algebraic' properly#2108
dlang-bot merged 1 commit intodlang:masterfrom
BorisCarvajal:import_Algebraic

Conversation

@BorisCarvajal
Copy link
Member

@BorisCarvajal BorisCarvajal commented Feb 21, 2021

I'm currently trying to solve a DMD bug and that has revealed one line relying on it because if you check the code you can realize there is no way to access std.variant.Algebraic from here because the import std.variant; from lexer.d is not public.
I suppose these are traces of when imports were public by default.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @BorisCarvajal! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@dlang-bot dlang-bot merged commit aec9491 into dlang:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants