Tests: Use TestDub FSEntry constructor for more accurate tests #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5372576 bin/dub
-rough build time=64s
+rough build time=65sFull build output |
Geod24
force-pushed
the
mlang/RewriteCtors
branch
2 times, most recently
from
4857848 to
3d38000
Compare
|
Wonderful, this uncovered a bug, which is now fixed. |
Geod24
force-pushed
the
mlang/RewriteCtors
branch
2 times, most recently
from
ed76e94 to
21c2337
Compare
With our versioned path implementation, we have the following issue:
assert(NativePath("/foo").absolute); // Passes
assert(NativePath(NativePath("/foo").toNativeString()).absolute); // Fails
However, instead of fixing the implementation, we provide
a different root for the VFS, which is arguably simpler but
also more correct.
The previous approach added Packages in the PackageManager directly, completely sidestepping the scanning the PackageManager does, which is a behavior we absolutely want to test. By setting up the filesystem before we instantiate our `TestDub` instance, we can remove a bunch of exceptions / overrides, and get a much closer behavior to the final product.
Geod24
force-pushed
the
mlang/RewriteCtors
branch
from
21c2337 to
323eef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach added Packages in the PackageManager directly, completely sidestepping the scanning the PackageManager does, which is a behavior we absolutely want to test.
By setting up the filesystem before we instantiate our
TestDubinstance, we can remove a bunch of exceptions / overrides, and get a much closer behavior to the final product.