Windows installer: install mingw libs and improve VS selection #281

rainers · 2017-12-24T14:24:17Z

add mingw libraries to installation
add installer page to select VS installation
no need to patch sc.ini as dmd detects VS

@MartinNowak You will still have to add lld-link.exe to the extra folders.

The additional page only appears if no VS installation is detected and looks like this:

dlang-bot · 2017-12-24T14:24:17Z

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	15131	normal	curl.lib is not available in 32 bit mscoff format

wilzbach · 2017-12-24T14:36:11Z

create_dmd_release/build_all.d

@@ -487,6 +487,9 @@ int main(string[] args)
        extract(cacheDir~"/"~libCurl, workDir~"/windows/old-dmd/");
        // Get updated OMF import libraries
        extract(cacheDir~"/"~omflibs, workDir~"/windows/old-dmd/dmd2/windows/lib/");
+
+        // grab mingw sources
+        run("git clone --depth 1 --branch 5.0-active https://git.code.sf.net/p/mingw/mingw-org-wsl.git " ~ workDir ~ "/clones/mingw");


How about checking out a specific tag or commit here to avoid breakage if the branch gets updated?

How about checking out a specific tag or commit here to avoid breakage if the branch gets updated?

Maybe better, but 5.0-active is a release branch with only little activity, the real work seems to happen on 5.1-trunk.

Ah I just saw the -active

Let's use a cacheable tarball (for a fixed commit), just had lots of issues with sourceforge's git. Not too convinced that their service is reliable.

MartinNowak · 2017-12-29T13:39:52Z

Looks great @rainers.

Saw it a little late, I'd rather target 2.079 with this change, since there isn't much time for testing the installer.

Maybe select and mark 2017 as (default)? A bit more information would be helpful to make that choice.

You will still have to add lld-link.exe to the extra folders.

We do I get the binaries from? Should we handle this like curl?

rainers · 2017-12-29T14:08:36Z

Saw it a little late, I'd rather target 2.079 with this change, since there isn't much time for testing the installer.

Yeah, unfortunately this didn't get enough attention. So targetting next release is fine with me. A nightly build having the mingw extras would be nice. Maybe we can set an Appveyor task to build the installer.

Maybe select and mark 2017 as (default)?

It's already the default but moving it into first place, too, makes sense.

We do I get the binaries from? Should we handle this like curl?

Where do you get these from? I see different sources:

lld-link.exe can be made available for download similarily. IIRC you recently built it yourself. If you want, I can do that, too (I'm usually building from LLVM master).

MartinNowak · 2017-12-29T21:45:38Z

IIRC you recently built it yourself.

That was quite messy IIRC.

If you want, I can do that, too (I'm usually building from LLVM master).

Even better, let's put the manual in the wiki and/or do it via a build script.

Where do you get these from? I see different sources:

Then let's put it to http://downloads.dlang.org/other/
Do we have proper versions to build?

Maybe we can set an Appveyor task to build the installer.

That doesn't really fit into an automated release building. A task to build lld would work fine though.

MartinNowak · 2017-12-29T21:53:49Z

I'll look into automating the lld-link build in the next couple of days.

rainers · 2017-12-30T08:06:24Z

Even better, let's put the manual in the wiki and/or do it via a build script.

Building lld is described on the LLVM page: https://lld.llvm.org/windows_support.html. TBH it didn't work out right so simple for me, too, but I think that happened because I was trying to integrate it with my current working copy of LLVM.

Then let's put it to http://downloads.dlang.org/other/

How about creating a new "extras" file there, the stuff in the semitwist file are pretty dated. I wouldn't mind if the 20 year old "debugger" in there would be removed, too.

Do we have proper versions to build?

I'm currently using the latest in the hope a couple of issues are resolved. Last time I checked /MAP is not supported (/lldmap exists instead with different output format) and quotes in the library search path are not removed.

A task to build lld would work fine though.

I suspect building LLD from scratch will take too long for an appveyor job.

rainers · 2017-12-30T09:25:05Z

I suspect building LLD from scratch will take too long for an appveyor job.

Just rebuilt locally with a quad-core mobile i7 and it took about 23 minutes without the cloning. Appveyor seems to have 2 cores, could be close for the timeout on appveyor (50 miutes IIRC).

rainers · 2017-12-30T12:51:09Z

I suspect building LLD from scratch will take too long for an appveyor job.

Takes about 40 minutes: #286

MartinNowak · 2018-02-17T15:51:28Z

create_dmd_release/build_all.d

@@ -487,6 +487,9 @@ int main(string[] args)
        extract(cacheDir~"/"~libCurl, workDir~"/windows/old-dmd/");
        // Get updated OMF import libraries
        extract(cacheDir~"/"~omflibs, workDir~"/windows/old-dmd/dmd2/windows/lib/");
+
+        // grab mingw sources
+        run("git clone --depth 1 --branch 5.0-active https://git.code.sf.net/p/mingw/mingw-org-wsl.git " ~ workDir ~ "/clones/mingw");


Having issues with sourceforge git reliability (right now). Any mirrors?

MartinNowak · 2018-02-17T16:19:18Z

create_dmd_release/build_all.d

@@ -487,6 +487,9 @@ int main(string[] args)
        extract(cacheDir~"/"~libCurl, workDir~"/windows/old-dmd/");
        // Get updated OMF import libraries
        extract(cacheDir~"/"~omflibs, workDir~"/windows/old-dmd/dmd2/windows/lib/");
+
+        // grab mingw sources
+        run("git clone --depth 1 --branch 5.0-active https://git.code.sf.net/p/mingw/mingw-org-wsl.git " ~ workDir ~ "/clones/mingw");


Let's use a cacheable tarball (for a fixed commit), just had lots of issues with sourceforge's git. Not too convinced that their service is reliable.

- add mingw libraries to installation - add installer page to select VS installation - no need to patch sc.ini as dmd detects VS

MartinNowak · 2018-02-17T18:26:06Z

I see, this depends on #289 now.

- build on appveyor using the build-mingw-libs and build-lld branches - also fixes Issue 15131 - curl.lib is not available in 32 bit mscoff format

rainers · 2018-02-19T22:06:08Z

Thanks for taking care of these.

rainers mentioned this pull request Dec 24, 2017

create dmd "light" installer on windows #271

Closed

wilzbach reviewed Dec 24, 2017

View reviewed changes

rainers mentioned this pull request Dec 29, 2017

VS detection: fallback to lld-link and the mingw libs if no SDK/VC installation found dlang/dmd#7500

Merged

MartinNowak changed the base branch from stable to master December 29, 2017 22:10

dlang-bot added needs rebase and removed needs rebase labels Jan 1, 2018

dlang-bot added the needs rebase label Jan 15, 2018

MartinNowak added this to the 2.079.0 milestone Feb 17, 2018

MartinNowak changed the base branch from master to stable February 17, 2018 15:32

MartinNowak force-pushed the vsdetect branch from e9f717a to 1306c50 Compare February 17, 2018 15:46

dlang-bot removed the needs rebase label Feb 17, 2018

MartinNowak reviewed Feb 17, 2018

View reviewed changes

Windows installer:

fed5e7e

- add mingw libraries to installation - add installer page to select VS installation - no need to patch sc.ini as dmd detects VS

MartinNowak force-pushed the vsdetect branch 3 times, most recently from d783b92 to 898cbe9 Compare February 17, 2018 18:25

add pre-built mingw coff libs and lld-link.exe

04d3fc6

- build on appveyor using the build-mingw-libs and build-lld branches - also fixes Issue 15131 - curl.lib is not available in 32 bit mscoff format

MartinNowak force-pushed the vsdetect branch from 898cbe9 to 04d3fc6 Compare February 17, 2018 21:05

dlang-bot added the Bug Fix label Feb 17, 2018

MartinNowak merged commit cc288bb into dlang:stable Feb 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows installer: install mingw libs and improve VS selection #281

Windows installer: install mingw libs and improve VS selection #281

rainers commented Dec 24, 2017

dlang-bot commented Dec 24, 2017 •

edited

Loading

wilzbach Dec 24, 2017

rainers Dec 24, 2017

wilzbach Dec 24, 2017

MartinNowak Feb 17, 2018

MartinNowak commented Dec 29, 2017

rainers commented Dec 29, 2017

MartinNowak commented Dec 29, 2017

MartinNowak commented Dec 29, 2017

rainers commented Dec 30, 2017

rainers commented Dec 30, 2017

rainers commented Dec 30, 2017

MartinNowak Feb 17, 2018

MartinNowak Feb 17, 2018

MartinNowak commented Feb 17, 2018

rainers commented Feb 19, 2018 •

edited

Loading

Windows installer: install mingw libs and improve VS selection #281

Windows installer: install mingw libs and improve VS selection #281

Conversation

rainers commented Dec 24, 2017

dlang-bot commented Dec 24, 2017 • edited Loading

Bugzilla references

wilzbach Dec 24, 2017

Choose a reason for hiding this comment

rainers Dec 24, 2017

Choose a reason for hiding this comment

wilzbach Dec 24, 2017

Choose a reason for hiding this comment

MartinNowak Feb 17, 2018

Choose a reason for hiding this comment

MartinNowak commented Dec 29, 2017

rainers commented Dec 29, 2017

MartinNowak commented Dec 29, 2017

MartinNowak commented Dec 29, 2017

rainers commented Dec 30, 2017

rainers commented Dec 30, 2017

rainers commented Dec 30, 2017

MartinNowak Feb 17, 2018

Choose a reason for hiding this comment

MartinNowak Feb 17, 2018

Choose a reason for hiding this comment

MartinNowak commented Feb 17, 2018

rainers commented Feb 19, 2018 • edited Loading

dlang-bot commented Dec 24, 2017 •

edited

Loading

rainers commented Feb 19, 2018 •

edited

Loading