Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MinGW-based libs to MinGW-w64 v8.0.0 #474

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Nov 2, 2020

I've compared the crucial {msvcr*,ucrtbase}.def.in files against v7.0.0, and they don't seem to feature any relevant changes.

See http://mingw-w64.org/doku.php/versions for the changelog; Direct3D 12 is one of the additions.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

I've compared the crucial {msvcr*,ucrtbase}.def.in files against v7.0.0,
and they don't seem to feature any relevant changes.

See http://mingw-w64.org/doku.php/versions for the changelog; Direct3D
12 is one of the additions.
kinke added a commit to ldc-developers/mingw-w64-libs that referenced this pull request Nov 2, 2020
[And sync with upstream.]

I've compared the crucial {msvcr*,ucrtbase}.def.in files against v7.0.0,
and they don't seem to feature any relevant changes.

See http://mingw-w64.org/doku.php/versions for the changelog; Direct3D
12 is one of the additions.

Corresponding upstream PR is dlang/installer#474.
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@rainers can you please take a look?

@rainers
Copy link
Member

rainers commented Nov 3, 2020

Had a cursory look at the artifact, looks good. One library name was corrected when compared to the Windows SDK (rstrmgr.lib -> rstrtmgr.lib).
To make it into the installer, we need to make a release here and update build_all.d.

@rainers rainers merged commit fcb3ccf into dlang:master Nov 3, 2020
@wilzbach
Copy link
Member

wilzbach commented Nov 3, 2020

Github release for resource caching: https://github.com/dlang/installer/releases/tag/mingw-libs-8.0.0
GitHub build_all.d PR: #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants