-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make File.byLineCopy
usable in @safe
contexts
#10606
Conversation
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10606" |
Do not bother reviewing this yet. |
Parent PR merged. |
34df4a5
to
cae8117
Compare
Still WIP. |
Oh nice, this got caught even by GHA tests. |
The PR and commit titles have some grammar issues but this otherwise looks good. |
How about “Make |
that works |
If you got something better, I’d be quite happy to use that instead, too :) |
File.byLineCopy
to be @safe
to useFile.byLineCopy
usable in @safe
contexts
That label removal was GitHub’s lack of lost-update handling. (i.e. all I did was adding the “enhancement” label.) |
This depends on #9035.
Fixes one of the objectives from #10605.