Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make File.byLineCopy usable in @safe contexts #10606

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

0xEAB
Copy link
Member

@0xEAB 0xEAB commented Jan 1, 2025

This depends on #9035.
Fixes one of the objectives from #10605.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 1, 2025

Thanks for your pull request, @0xEAB!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10606"

@0xEAB
Copy link
Member Author

0xEAB commented Jan 1, 2025

Do not bother reviewing this yet.
Needs a rebase once its “parent” PR is ready and AFAICT breaks one of the existing unittests.

@thewilsonator
Copy link
Contributor

Parent PR merged.

@0xEAB 0xEAB force-pushed the byLineCopy-safe branch 3 times, most recently from 34df4a5 to cae8117 Compare January 2, 2025 00:43
@0xEAB
Copy link
Member Author

0xEAB commented Jan 2, 2025

Still WIP.
cae8117 is expected to fail buildkite as it makes @safe-ty assumptions only valid with DIP1000 enabled.

@0xEAB
Copy link
Member Author

0xEAB commented Jan 2, 2025

Oh nice, this got caught even by GHA tests.

@0xEAB 0xEAB marked this pull request as ready for review January 2, 2025 01:08
@thewilsonator
Copy link
Contributor

The PR and commit titles have some grammar issues but this otherwise looks good.

@0xEAB
Copy link
Member Author

0xEAB commented Jan 2, 2025

The PR and commit titles have some grammar issues but this otherwise looks good.

How about “Make File.byLineCopy usable in @safe contexts”?

@thewilsonator
Copy link
Contributor

that works

@0xEAB
Copy link
Member Author

0xEAB commented Jan 2, 2025

that works

If you got something better, I’d be quite happy to use that instead, too :)

@0xEAB 0xEAB changed the title Upgrade File.byLineCopy to be @safe to use Make File.byLineCopy usable in @safe contexts Jan 2, 2025
@0xEAB
Copy link
Member Author

0xEAB commented Jan 2, 2025

That label removal was GitHub’s lack of lost-update handling. (i.e. all I did was adding the “enhancement” label.)
@thewilsonator feel free to add it again.

@thewilsonator thewilsonator merged commit 35c492c into dlang:master Jan 2, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants