-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix %*s handling by formattedRead() #10654
Fix %*s handling by formattedRead() #10654
Conversation
Thanks for your pull request and interest in making D better, @nicolo-mn! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10654" |
please add the test case from #10598 as a |
Thank you for your review @thewilsonator. A |
@thewilsonator Is it possible that the checks have been interrupted without any errors? I see the message |
Some of those time out |
Thanks for running the tests one more time. Unfortunately, the same check on |
This PR addresses issue #10598. The problem lies in the lack of handling for certain specifiers in the
skipData
function ofstd/format/internal/read.d
. Theswitch
statement only handles%c
,%d
and%u
. Handling of%s
was added but the problem is analogous in the case of other specifiers. For example, the program:outputs this:
Therefore, the remaining specifiers also need to be handled. Should I include them in this PR, or should I open a separate, more general issue and PR for this problem?