Fix #10680 - std.getopt doesn't accept const(string)[] anymore #10684
Conversation
…ction, just return the value and assign it to the receiver. Renamed the conversion function and also cleaned up all the `typeof` calls, which were very verbose.
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
|
Thanks Steven for taking care of this! (FWIW, needed to compile reggae...) - I guess the simple GitHub issue ref is enough for the upcoming changelog generator? |
|
Hm... I don't know the magic thing to say to get the issue to auto-close... |
I never seem to be able to get it right. The documentation explaining it is here: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue Looking at that page and at the title here though, I would have thought that it would have worked. |
|
Oh! I know. This only happens if you merge to master. OK. |
Hm... reggae should be added to the buildkite CI. It's very much an integral part of the ecosystem, and we should not be able to break it without CI complaining. |
Instead of passing receiver into the conversion function, just return the value and assign it to the receiver. Renamed the conversion function and also cleaned up all the `typeof' calls, which were very verbose. libphobos/ChangeLog: * src/MERGE: Merge upstream phobos 79cbde1ab. Reviewed-on: dlang/phobos#10684
Reworked the conversion function so it returns the value instead of accepting a (possibly const) pointer.