10826 use cmp and abs to find larger NaN payload #10895
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getNaNPayload(x)` returns a value even if `x` is not NaN, so it is up to the caller to verify that `x` is a NaN before calling `getNaNPayload(x)`. This means it is not a good option for determining for determining which of a set of values has the largest NaN payload when it is only known that at least one value is NaN. `cmp(x, y)` can be used. since to orders -NaN as before -infinity and NaN as after infinity. When two NaN with the same sign are compared, the one with the larger payload is considered larger. This means that `cmp(abs(x), abx(y))` will find the NaN with the larger payload when it is only known that at least one of `x` or `y` is NaN.
Contributor
|
Thanks for your pull request and interest in making D better, @tedgin! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + phobos#10895" |
thewilsonator
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getNaNPayload(x)returns a value even ifxis not NaN, so it is up to the caller to verify thatxis a NaN before callinggetNaNPayload(x). This means it is not a good option for determining for determining which of a set of values has the largest NaN payload when it is only known that at least one value is NaN.cmp(x, y)can be used. since to orders -NaN as before -infinity and NaN as after infinity. When two NaN with the same sign are compared, the one with the larger payload is considered larger. This means thatcmp(abs(x), abx(y))will find the NaN with the larger payload when it is only known that at least one ofxoryis NaN.I apologize for so many merge requests. I didn't know until today that getNaNPayload would return something other than zero when called with a value that isn't NaN.