-
-
Notifications
You must be signed in to change notification settings - Fork 746
add std.string.outdent #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c1155f5
Added (ctfe-able) std.string.outdent
f72551e
Added (ctfe-able) std.string.outdent
6474f81
tabs->spaces
ba7390d
Incorporated suggestions and fixes
02453a4
Ugh, I don't think I'll ever get used to space-indentation...
4b9641e
Remove ctfe_split: split is now CTFEable
3249523
Remove obsolete split unittests.
716143e
Merge branch 'master' of https://github.com/D-Programming-Language/ph…
2d6636c
Removed remaining ctfe_ functions as they are no longer needed.
a342dbf
== "" --> .empty
6724586
Merge branch 'master' of https://github.com/D-Programming-Language/ph…
39cedb6
Merge branch 'master' of https://github.com/D-Programming-Language/ph…
aa38e84
Merge branch 'master' of https://github.com/D-Programming-Language/ph…
89231d4
Turns out that outdent's ctfe_strip* helpers are still needed.
430f8a3
Made outdent's nested funcs static.
c1b1748
Use phobos's goofy formatting convention.
87169ce
tabs -> spaces (for the 500th time...)
e5bd38f
Merge branch 'master' of https://github.com/D-Programming-Language/ph…
50149d8
ctfe_stripLeft no longer needed.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should augment these tests to test multiple string types. For an example, look at
std.string.indexOf. It usesforeachandTypeTuple. In the extreme case, you can test every variation of character type and mutability, but at minimum, it should be tested withstring,wstring, anddstring. You should also test some non-ASCII characters.'\U00010143'is used in several tests in std.string and std.utf, because it's multiple code units for bothcharandwchar. That'll help catch bugs due to code that assumes that a code point is a single code unit.