-
-
Notifications
You must be signed in to change notification settings - Fork 746
Add optional KeepTerminator param to splitLines. #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
std/string.d
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is trailing whitespace is this function that needs to be cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it's not a big deal, but the function's signature would be easier to read if the = had spaces around it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"There is trailing whitespace is this function that needs to be cleaned up."
I turned on Visible Whitespace in my editor, but I don't see any.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, because I'm seeing 11 spaces on lines 1408 and 1413, both of which should be completely empty. I don't know why you're not seeing them in your editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, you mean on the blank lines. I've never paid much attention to whitespace on blank lines before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I set up my editor to highlight all tabs and trailing whitespace, so they become very obvious, very fast.
Add optional KeepTerminator param to splitLines.
|
Merged. |
Improve contributors script merged-on-behalf-of: Vladimir Panteleev <github@thecybershadow.net>
As suggested here: #277