Skip to content

Conversation

@Abscissa
Copy link
Contributor

As suggested here: #277

std/string.d Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace is this function that needs to be cleaned up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it's not a big deal, but the function's signature would be easier to read if the = had spaces around it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"There is trailing whitespace is this function that needs to be cleaned up."

I turned on Visible Whitespace in my editor, but I don't see any.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, because I'm seeing 11 spaces on lines 1408 and 1413, both of which should be completely empty. I don't know why you're not seeing them in your editor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, you mean on the blank lines. I've never paid much attention to whitespace on blank lines before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I set up my editor to highlight all tabs and trailing whitespace, so they become very obvious, very fast.

jmdavis added a commit that referenced this pull request Sep 30, 2011
Add optional KeepTerminator param to splitLines.
@jmdavis jmdavis merged commit 9b41185 into dlang:master Sep 30, 2011
@jmdavis
Copy link
Member

jmdavis commented Sep 30, 2011

Merged.

marler8997 pushed a commit to marler8997/phobos that referenced this pull request Nov 10, 2019
Improve contributors script
merged-on-behalf-of: Vladimir Panteleev <github@thecybershadow.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants