Revert "Implement issue# 13996. Add File.tempFile."

[WalterBright]

Reverts #2956
because of https://issues.dlang.org/show_bug.cgi?id=14539

[MartinNowak]

So what's the lesson here? We can't add a function because it increases the binary size? Ridiculous, let's please fix the compiler instead.

[MartinNowak]

See dlang/dmd#4638 and Issue 13242 – imported aliases should be analyzed lazily.

[WalterBright]

The issue is this function cannot be added until whatever reason it bloats the executable size is fixed. I.e. regressions should not be pulled, regardless of cause.

[andralex]

Auto-merge toggled on

[WalterBright]

This is why checks for executable size bloat should be in the test suite.

[andralex]

@MartinNowak do we have that check around yet? I recall you mentioned it at some point.

[MartinNowak]

Yes, here https://github.com/D-Programming-Language/dmd/blob/82b031c22f18334a7edeff437260b6802070a9e3/test/runnable/test13117.d.
Someone should update the thresholds. We can lower the tolerance to maybe 1%, it cannot be zero because the would affect too many pull requests.

[MartinNowak]

The issue is this function cannot be added until whatever reason it bloats the executable size is fixed.

Sure, but the right direction to fix bugs is going forward not backward.
It was a huge effort to get this functionality into phobos, and not it's reverted because of compiler issues the phobos devs aren't accountable for.

[WalterBright]

I'm sorry about that, but we should never pull something that causes regressions, even if it is not the fault of the new code. This is not about assigning blame.

[schveiguy]

Can we close the regression now? It's still open.

[andralex]

@MartinNowak instead of having a tolerance the better policy is to update it on a case basis where justified. @schveiguy yes, could you please close - thanks.